[izpack-devel] FW: Fix properly position components whileswitchingbetween packs

[Amit Bhayani]

Hi Julien,

 

I see that the TwoColumnLayout.java is checked into the SVN head.
However while checking in the Boolean values removedLeft and
removedRight were discarded in method removeLayoutComponent. While
conducting a test today I realized that they are important. Look at line


 

removedLeft = left.remove(constraints);

removedRight = right.remove(constraints);

 

I have made the changes and attaching the patch file
(TwoColumnLayout.txt)

 

Regards,

Amit.

________________________________

From: izpack-devel-bounces at lists.berlios.de
[mailto:izpack-devel-bounces at lists.berlios.de] On Behalf Of Amit Bhayani
Sent: Thursday, July 27, 2006 11:30 PM
To: izpack-devel at lists.berlios.de
Subject: [izpack-devel] FW: Fix properly position components
whileswitchingbetween packs

 

Sorry the TwoColumnLayoutTest.java was missing.

 

Amit.

 

________________________________

From: izpack-devel-bounces at lists.berlios.de
[mailto:izpack-devel-bounces at lists.berlios.de] On Behalf Of Amit Bhayani
Sent: Thursday, July 27, 2006 11:28 PM
To: izpack-devel at lists.berlios.de
Subject: [izpack-devel] Fix properly position components while
switchingbetween packs

 

Hello Friends,

 

I am using Installer for our specific requirement and came across a bug
where if User changes the Packs selected, component layout gets ugly. I
have seen other users too facing this problem.

 

To fix this I have made changes in removeLayoutComponent(Component) of
TwoColumnLayout Class. I am attaching the patch ( PFA patch1.txt ) for
the changes made. I have quickly coded a small application making use of
TwoColumnLayout. PFA TwoColumnLayoutTest.java. This is just for testing
and by no means a quality code.

 

Please let me know what you think about the changes.

 

Thanks and Regards,

Amit.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.berlios.de/pipermail/izpack-devel/attachments/20060819/4569b25c/attachment.html 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: TwoColumnLayout.txt
Url: https://lists.berlios.de/pipermail/izpack-devel/attachments/20060819/4569b25c/attachment.txt