[izpack-devel] InstallationGroupPanel

[Jeff Gordon]

I'd like to propose the InstallationGroupPanel table display be changed to
remove the description from the radio button display (basically just
removing the center column).  It is already displayed below as text and
there's no way any descriptive text could all be displayed in the small
space provided.  In addition, I propose the size column be right justified
to display numerical value-derived text in a more consistent manner.
Original code is commented for comparison in the patch below.

- Jeff Gordon



Index: InstallationGroupPanel.java
===================================================================
--- InstallationGroupPanel.java    (revision 1977)
+++ InstallationGroupPanel.java    (working copy)
@@ -59,6 +59,8 @@
 import com.izforge.izpack.util.AbstractUIHandler;
 import com.izforge.izpack.util.Debug;
 import com.izforge.izpack.util.OsConstraint;
+import javax.swing.SwingConstants;
+import javax.swing.table.DefaultTableCellRenderer;


 /**
@@ -148,6 +150,10 @@
           }
         };
         tcm.getColumn(0).setCellRenderer(radioButtonRenderer);
+
+        DefaultTableCellRenderer renderer = new DefaultTableCellRenderer();
+        renderer.setHorizontalAlignment(SwingConstants.RIGHT);
+        tcm.getColumn(1).setCellRenderer(renderer);

         //groupsTable.setColumnSelectionAllowed(false);
         //groupsTable.setRowSelectionAllowed(true);
@@ -499,9 +505,9 @@
     protected TableModel getModel(HashMap groupData)
     {
         String c1 = parent.langpack.getString("
InstallationGroupPanel.colNameSelected");
-        String c2 = parent.langpack.getString("
InstallationGroupPanel.colNameInstallType");
+        //String c2 = parent.langpack.getString("
InstallationGroupPanel.colNameInstallType");
         String c3 = parent.langpack.getString("
InstallationGroupPanel.colNameSize");
-        String[] columns = {c1, c2, c3};
+        String[] columns = {c1, c3};
          DefaultTableModel model = new DefaultTableModel (columns, 0)
          {
             public boolean isCellEditable (int row, int column)
@@ -567,7 +573,8 @@
             }
             buttonGroup.add(btn);
             String sizeText = gd.getSizeString();
-            Object[] data = { btn, gd.description, sizeText};
+            //Object[] data = { btn, gd.description, sizeText};
+            Object[] data = { btn, sizeText};
             model.addRow(data);
             count ++;
         }
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.berlios.de/pipermail/izpack-devel/attachments/20080109/4c2141a3/attachment.html