[izpack-devel] Re : Re : Re : [izpack-users] Re : Tr : Localizingshortcuts

[Loic]

Hi all,

I downloadeed izPack's latest release (3.10.2 - build 2007.05.11) and used it to compile my install project.
I noted that the "shortcut localization" patch we had set up with Klaus at the end of april (see messages below) doesn't seem to have been included in the release (though Klaus had checked it into the trunk two weeks before the release, and that it stills appear correctly in the SVN version - and works as expected if I compile my own standalone-comipler.jar).

I also noted that the documentation in the release hasn't been updated either (which is coherent with the patch not being included), but the svn documentation has not been updated either. Maybe you'll want to commit the patch I sent you so that the feature is properly documented.

Is 3.10.3 planned already ?
Can I sugggest adding "check that shortcut localization is properly included" to the before-release check-list ?

Thanks,

Loïc

----- Message d'origine ----
De : Loic <lbndev at yahoo.fr>
À : izpack-devel at lists.berlios.de
Envoyé le : Vendredi, 27 Avril 2007, 12h25mn 22s
Objet : [izpack-devel] Re : Re : [izpack-users] Re : Tr : Localizingshortcuts

Hi Klaus,

You are probably right about the way this should be done. Sorry I haven't gotten far enough into izPack code to pick the ResourceManager at first. Thank you for the review and improvements.

I have tested your SVN version and confirm it works as expected (uses language files and properly fallbacks to defaults when needed).

The documentation I have written should not need to be affected by your chenges since the overall behavior is the same.

Thank you very much,

Loïc

----- Message d'origine ----
De : "Bartz, Klaus" <Klaus.Bartz at coi.de>
À : izpack-devel at lists.berlios.de
Envoyé le : Vendredi,
 27 Avril 2007, 11h54mn 35s
Objet : Re: [izpack-devel] Re : [izpack-users] Re : Tr : Localizingshortcuts

Hi Loïc,
now I have had a little bit time to look into the given patch.
It is not good that the shortcut config file can not be localized
until now. Thanks for the hint and for the patch.
Testing it I have seen, that there is already a methode to resolve
locale dependencies (ResourceManager::getInputStream).
This will be better because in near future I will change the locale
determining from
_ccc
to
_ll_CC
Additional I am not amused that the locale identifier ofthen is written
to the end of the file name. One result is, that syntax highlighting
will not start automatically then.
Therefore I have changed the patch to this behavior and checked in into
trunk.

Modified:
 izpack-src/trunk/src/lib/com/izforge/izpack/panels/ShortcutPanel.java
===================================================================
--- izpack-src/trunk/src/lib/com/izforge/izpack/panels/ShortcutPanel.java    2007-04-24 14:50:54 UTC (rev 1818)
+++ izpack-src/trunk/src/lib/com/izforge/izpack/panels/ShortcutPanel.java    2007-04-27 09:34:36 UTC (rev 1819)
@@ -756,11 +756,12 @@
 
         try
         {
-            input = parent.getResource(TargetFactory.getCurrentOSPrefix() + SPEC_FILE_NAME);
+            input =
 ResourceManager.getInstance().getInputStream(
+                    TargetFactory.getCurrentOSPrefix() + 
+ SPEC_FILE_NAME);
         }
         catch (ResourceNotFoundException rnfE)
         {
-            input = parent.getResource(SPEC_FILE_NAME);
+            input = 
+ ResourceManager.getInstance().getInputStream(SPEC_FILE_NAME);
         }
 
         if (input == null)

I have tested a little bit, but it will be good if you test also.

Fabrice, can you look that the docu will also be OK for the
changed
 internals? Thanks.


Cheers

Klaus


> -----Original Message-----
> From: izpack-devel-bounces at lists.berlios.de 
> [mailto:izpack-devel-bounces at lists.berlios.de] On Behalf Of miraodb
> Sent: Wednesday, April 25, 2007 4:24 PM
> To: izpack-devel at lists.berlios.de
> Subject: Re: [izpack-devel] Re : [izpack-users] Re : Tr : 
> Localizingshortcuts
> 
> 
> Hi,
> 
> I'm taking care of that. Thx for the docu update.
> 
> Cheers,
> Fabrice
> 
> ----- Original Message -----
> From: "Loic" <lbndev at yahoo.fr>
> To: <izpack-devel at lists.berlios.de>
> Sent: Wednesday, April 25, 2007 5:35 AM
> Subject: [izpack-devel] Re : [izpack-users] Re : Tr : 
> Localizing shortcuts
> 
> Hi Klaus (& list),
> 
> As promised, attached are the patches for the documentation, 
> related to my 
> patch on
 shortcutspecs posted yesterday.
> I am no expert in docbook so I updated both xml and html 
> files. Maybe you'll 
> want to use the xml file to regenereate the html one instead 
> of patching it 
> ?
> 
> Cheers,
> 
> Loïc
> P.S. : switching this thread to izpack-devel as the patches 
> seem to be best 
> suited here than on izpack-users. Sorry for cross-posting the 
> patch to both 
> lists yesterday, but I felt I needed to close my question 
> from the day 
> before there.
> 
> ----- Message d'origine ----
> De : "Bartz, Klaus" <Klaus.Bartz at coi.de>
> À : izpack-users at lists.berlios.de
> Envoyé le : Mardi, 24 Avril 2007, 12h26mn 45s
> Objet : Re: [izpack-users] Re :  Tr : Localizing shortcuts
> 
> Nachricht
> 
> 
> DIV {
> MARGIN:0px;}
> 
> 
> 
> Hi
>
 Loic,
> 
> then
> we are on the same side of the river :-)
> 
> English is also not my native language. May
> be about that I take words
> 
> more
> on an assay-balance as others. Sorry.
> 
> 
> 
> Cheers
> 
> 
> 
> Klaus
> 
> 
> 
> 
>   -----Original Message-----
> From:
>   izpack-users-bounces at lists.berlios.de
>   [mailto:izpack-users-bounces at lists.berlios.de] On Behalf Of
>   Loic
> Sent: Tuesday, April 24, 2007 12:10 PM
> To:
>   izpack-users at lists.berlios.de
> Subject: [izpack-users] Re : Tr :
>   Localizing shortcuts
> 
> 
> 
> 
>   Hi
>   Klaus,
> 
> Thank you for your reply.
> Sorry for not updating the
>   documentation. I will as
 soon as I can and post the patch.
> 
>