[izpack-devel] Additions to executefile element and ProcessPanel panel

[Tino Schwarze]

Hi,

On Wed, Jan 04, 2006 at 11:40:07AM +0200, donald wrote:
> I have made the following additions to the ProcessPanel code which I 
> could add to the patch manager if anyone thinks they might need them or 
> would like to suggest changes or improvements:
> 
> 1] stdin element in executefile
> Description:
> Added an stdin element to the executefile element to allow input from a 
> user or from a named pipe.
> 
> Motivation:
> Many console based executables require simple input eg answering yes or 
> no to accept a license. This change allows the display of a text box in 
> the ProcessPanel only for those executefile's that have an stdin element.
> 
> Source Files:
> ProcessPanel.java, ProcessPanelWorker.java, AbstractUIProcessHandler 
> (ProcessPanelAutomationHelper due to interface changes in 
> AbstractUIProcessHandler)
> 
> Example:
> <executefile name="$JAVA_HOME/jai-1_1_2_01-lib-linux-i586-jre.bin" 
> pwd="$JAVA_HOME" >
>       <stdin type="user">            <!-- user input (text box in 
> ProcessPanel) -->

So, does the user see the question he's asked?

> 2] pwd attribute for executefile element

[...]

Sounds good.

> 3] env elements for executefile element

Sounds useful too.

> Description:
> Added a env element similar to the arg element for executefile that 
> allows the user to specify environment variables when executing the 
> specified application.
> 
> Motivation:
> There may be occasions when a application requires a environment 
> variable to be set eg LD_LIBRARY_PATH.
> 
> Example
> <executefile name="/bin/bash" pwd="/" >
>   <env>LD_LIBRARY_PATH=./
>   </env>

I'd use a pure XML syntax here:
<env name="CC" value="..." />
or maybe support
<env name="CC">gcc-3.4</env> 
too.

Cool stuff, should be very useful, so please add the patches.

Bye, Tino.