[izpack-devel] Patch: InstallerGroupPanel reading description fromvariable not working

[Bartz, Klaus]

Hi,
until jet I have not worked with the InstallerGroupPanel, therefore I do not know whether the
key name is not the right if the langpack do not contain a value for the key or not. If this
behavior is wrong, it should be fixed in the class InstallationGroupPanel; but please 
without the wrong comment. This behavior is written in the JavaDoc...
 
In principle it is a good idea to return the key symbol if the value not found. Julien has
made it some years ago to prevent the installation to fail with a null pointer exception.
 
Cheers
 
Klaus
 

-----Original Message-----
From: izpack-devel-bounces at lists.berlios.de [mailto:izpack-devel-bounces at lists.berlios.de]On Behalf Of Markus Schlegel
Sent: Monday, December 11, 2006 3:16 PM
To: izpack-devel at lists.berlios.de
Subject: [izpack-devel] Patch: InstallerGroupPanel reading description fromvariable not working


Due to the fact, that LocalDatabase.getString(key) returns the key if no such value could be found,  the now patched line never get's a chance to read the textfrom the defined variable.
This is now working again.
 
Index: C:/deron/tools/IzPack_TRUNK/src/lib/com/izforge/izpack/panels/InstallationGroupPanel.java
===================================================================
--- C:/deron/tools/IzPack_TRUNK/src/lib/com/izforge/izpack/panels/InstallationGroupPanel.java (revision 1665)
+++ C:/deron/tools/IzPack_TRUNK/src/lib/com/izforge/izpack/panels/InstallationGroupPanel.java (working copy)
@@ -383,7 +383,7 @@
             else
                 description = html;
         }
-        if (description == null)
+        if (description == null || key.equalsIgnoreCase(description)) //not a good idea, to return key if value not found...
             description = idata.getVariable(key);
         if (description == null)
             description = group + " installation";


-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.berlios.de/pipermail/izpack-devel/attachments/20061211/d6b2191d/attachment.html