[izpack-devel] The icon for the done button

Ryan Shillington Ryan.Shillington at troux.com
Wed Aug 23 23:34:33 CEST 2006 

Here's my change for the done button.  What do you think?

Index: lib/com/izforge/izpack/panels/FinishPanel.java
===================================================================
--- lib/com/izforge/izpack/panels/FinishPanel.java      (revision 1529)
+++ lib/com/izforge/izpack/panels/FinishPanel.java      (working copy)
@@ -48,10 +48,10 @@
     private static final long serialVersionUID = 3257282535107998009L;

     /** The automated installers generation button. */
-    private JButton autoButton;
+    protected JButton autoButton;

     /** The variables substitutor. */
-    private VariableSubstitutor vs;
+    protected VariableSubstitutor vs;

     /**
      * The constructor.
@@ -84,6 +84,7 @@
         parent.lockNextButton();
         parent.lockPrevButton();
 
parent.setQuitButtonText(parent.langpack.getString("FinishPanel.done"));
+        parent.setQuitButtonIcon("done");
         if (idata.installSuccess)
         {
             // We set the information
@@ -159,7 +160,7 @@
      * @param destination The path to translate.
      * @return The translated path.
      */
-    private String translatePath(String destination)
+    protected String translatePath(String destination)
     {
         // Parse for variables
         destination = vs.substitute(destination, null);
Index: lib/com/izforge/izpack/panels/SimpleFinishPanel.java
===================================================================
--- lib/com/izforge/izpack/panels/SimpleFinishPanel.java
(revision 1529)
+++ lib/com/izforge/izpack/panels/SimpleFinishPanel.java        (working
copy)
@@ -78,6 +78,7 @@
         parent.lockNextButton();
         parent.lockPrevButton();
 
parent.setQuitButtonText(parent.langpack.getString("FinishPanel.done"));
+        parent.setQuitButtonIcon("done");
         if (idata.installSuccess)
         {

Index: lib/com/izforge/izpack/installer/InstallerFrame.java
===================================================================
--- lib/com/izforge/izpack/installer/InstallerFrame.java
(revision 1529)
+++ lib/com/izforge/izpack/installer/InstallerFrame.java        (working
copy)
@@ -972,6 +972,11 @@
         quitButton.setText(text1);
     }

+    public void setQuitButtonIcon(String iconName)
+    {
+        quitButton.setIcon(icons.getImageIcon(iconName));
+    }
+
     /*
      * FocusTraversalPolicy objects to handle keybord blocking; the
declaration os Object allows to
      * use a pre version 1.4 VM.
Index: lib/com/izforge/izpack/installer/icons.xml
===================================================================
--- lib/com/izforge/izpack/installer/icons.xml  (revision 1529)
+++ lib/com/izforge/izpack/installer/icons.xml  (working copy)
@@ -5,6 +5,7 @@
     <icon res="/img/leftarrow.png" id="stepback"/>
     <icon res="/img/rightarrow.png" id="stepforward"/>
     <icon res="/img/stop.png" id="stop"/>
+    <icon res="/img/done.png" id="done"/>
     <icon res="/img/kcontrol.png" id="host"/>
     <icon res="/img/info.png" id="information"/>
     <icon res="/img/contents.png" id="history"/>
Index: img/installer/img/done.png
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream

Property changes on: img\installer\img\done.png
___________________________________________________________________
Name: svn:mime-type
   + application/octet-stream

-----Original Message-----
From: izpack-devel-bounces at lists.berlios.de
[mailto:izpack-devel-bounces at lists.berlios.de] On Behalf Of Miraodb
Sent: Wednesday, August 23, 2006 1:42 AM
To: izpack-devel at lists.berlios.de
Subject: Re: [izpack-devel] The icon for the done button

Hi Ryan,

I don't really like the icon either... we could make it optionial with a
variable or something... or with an attribute to the finishpanel or
simplefinishpanel.

I let you do the patch then... post it on the list before commiting.

Cheers and good luck... :-)
Fabrice
----- Original Message ----- 
From: "Ryan Shillington" <Ryan.Shillington at troux.com>
To: <izpack-devel at lists.berlios.de>; <elmar at grom.net>
Sent: Tuesday, August 22, 2006 6:48 PM
Subject: Re: [izpack-devel] The icon for the done button


> I don't feel strongly about the check mark one way or another.  Let me
> take care of the done button.  It'd be nice to make my first change an
> easy one :-).
>
> Ryan
>
> -----Original Message-----
> From: izpack-devel-bounces at lists.berlios.de
> [mailto:izpack-devel-bounces at lists.berlios.de] On Behalf Of Amit
Bhayani
> Sent: Tuesday, August 22, 2006 6:46 AM
> To: izpack-devel at lists.berlios.de; elmar at grom.net
> Subject: Re: [izpack-devel] The icon for the done button
>
> Sounds good idea!
> In addition to this in our specific case we also show
> IzPack3-head\src\img\installer\img\check32.png image on the
FinishPanel.
>
> I am attaching the gif image for your reference.
>
> What do you think if we have both?
>
> Amit.
>
> -----Original Message-----
> From: izpack-devel-bounces at lists.berlios.de
> [mailto:izpack-devel-bounces at lists.berlios.de] On Behalf Of Miraodb
> Sent: Tuesday, August 22, 2006 12:45 PM
> To: elmar at grom.net; izpack-devel at lists.berlios.de
> Subject: Re: [izpack-devel] The icon for the done button
>
> Hi Guyz,
>
> Shall i apply that ? It seems like a good idea to me.
> Any other opinion before commiting anythin ?
>
> cheers,
> Fabrice
> ----- Original Message ----- 
> From: "Elmar Grom" <elmar at grom.net>
> To: <izpack-devel at lists.berlios.de>
> Sent: Tuesday, August 22, 2006 5:27 AM
> Subject: Re: [izpack-devel] The icon for the done button
>
>
> > Hey, that's worth a chunk of money ~;o)
> >
> > Looks good
> >
> >     Elmar
> >   -----Original Message-----
> >   From: izpack-devel-bounces at lists.berlios.de
> > [mailto:izpack-devel-bounces at lists.berlios.de]On Behalf Of Ryan
> Shillington
> >   Sent: Monday, August 21, 2006 2:54 PM
> >   To: izpack-devel at lists.berlios.de
> >   Subject: [izpack-devel] The icon for the done button
> >
> >
> >   Hello friends,
> >
> >
> >
> >   During the install, the "Quit" button has a big red X as its icon,
> which
> > is very appropriate.  Unfortunately, at the end of the install, on
the
> > FinishPanel the text changes to done but the icon is still a big red
> X.
> Can
> > we change it to something nicer?  I got my UI designer to give me an
> IzPack
> > looking checkmark:
> >
> >
> >
> >   http://www.thebookhauler.com/izpack/done.png
> >
> >
> >
> >   What do you think?
> >
> >
> >
> >   Ryan
> >
> >   IMPORTANT NOTICE:
> >   This message may contain confidential information. If you have
> received
> > this e-mail in error, do not use, copy or distribute it. Do not open
> any
> > attachments. Delete it immediately from your system and notify the
> sender
> > promptly by e-mail that you have done so. Thank you.
> >
>
>
>
------------------------------------------------------------------------
> ----
> ----
>
>
> > _______________________________________________
> > izpack-devel mailing list
> > izpack-devel at lists.berlios.de
> > https://lists.berlios.de/mailman/listinfo/izpack-devel
> >
>
> _______________________________________________
> izpack-devel mailing list
> izpack-devel at lists.berlios.de
> https://lists.berlios.de/mailman/listinfo/izpack-devel
> _______________________________________________
> izpack-devel mailing list
> izpack-devel at lists.berlios.de
> https://lists.berlios.de/mailman/listinfo/izpack-devel
>
>

_______________________________________________
izpack-devel mailing list
izpack-devel at lists.berlios.de
https://lists.berlios.de/mailman/listinfo/izpack-devel

More information about the izpack-devel mailing list