[izpack-devel] private/protected conventions in IzPanels

[Bartz, Klaus]

Hi Ryan,
one point: I prefer getter and setter because then I can change the implementation
easier. Just the changes of layout with direct access of
defaultGridBagConstraints are involved.
 
Cheers
 
Klaus

-----Original Message-----
From: izpack-devel-bounces at lists.berlios.de [mailto:izpack-devel-bounces at lists.berlios.de]On Behalf Of Bartz, Klaus
Sent: Monday, August 07, 2006 8:45 AM
To: izpack-devel at lists.berlios.de
Subject: Re: [izpack-devel] private/protected conventions in IzPanels


Hi Ryan,
I agree that private variables sometimes nasty.
I think there are two reasons to make a variable private and not protected.
1. There is a rule never access a class variable from else where.
2. Protected variables should be commented.
 
Both do not say that a variable should not accessable. Therefore I think
we should comment them.
Whether getter and setter better or direct access is may be matter of
opinion.
 
Cheers
 
Klaus
 

-----Original Message-----
From: izpack-devel-bounces at lists.berlios.de [mailto:izpack-devel-bounces at lists.berlios.de]On Behalf Of Ryan Shillington
Sent: Friday, August 04, 2006 8:35 PM
To: izpack-devel at lists.berlios.de
Subject: [izpack-devel] private/protected conventions in IzPanels



Hey friends,

 

I've noticed that sometimes we make variables private instead of making them protected in IzPanels.  Is there a reason for that?    It's nice to make the variables protected because then it's much easier to modify the functionality of the panel.   

 

Ryan

IMPORTANT NOTICE:
This message may contain confidential information. If you have received this e-mail in error, do not use, copy or distribute it. Do not open any attachments. Delete it immediately from your system and notify the sender promptly by e-mail that you have done so. Thank you.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.berlios.de/pipermail/izpack-devel/attachments/20060807/9b94c29e/attachment.html