[izpack-changes] r1758 - izpack-src/branches/3.10/src/lib/com/izforge/izpack/util

[noreply at berlios.de]

Author: bartzkau
Date: 2007-02-21 09:36:30 +0100 (Wed, 21 Feb 2007)
New Revision: 1758

Modified:
   izpack-src/branches/3.10/src/lib/com/izforge/izpack/util/FileExecutor.java
Log:
"too many open files" bug at handling many processes fixed.


Modified: izpack-src/branches/3.10/src/lib/com/izforge/izpack/util/FileExecutor.java
===================================================================
--- izpack-src/branches/3.10/src/lib/com/izforge/izpack/util/FileExecutor.java	2007-02-20 17:48:15 UTC (rev 1757)
+++ izpack-src/branches/3.10/src/lib/com/izforge/izpack/util/FileExecutor.java	2007-02-21 08:36:30 UTC (rev 1758)
@@ -256,7 +256,6 @@
             stopThread(t2, errMonitor);
             output[0] = "";
             output[1] = e.getMessage() + "\n";
-            process.destroy();
         }
         catch (IOException e)
         {
@@ -264,6 +263,13 @@
             output[0] = "";
             output[1] = e.getMessage() + "\n";
         }
+        finally 
+        {
+        	// cleans up always resources like file handles etc.
+        	// else many calls (like chmods for every file) can produce
+        	// too much open handles.
+            if (process != null) process.destroy();
+        }
         return exitStatus;
     }