There is problem with uninstaller.jar content when we use installer jar with "(1)" for example install (1).jar it very often case when we download installer several times.

In this case JarMerge performs replaceAll with "(1)" that treated as regular expression.

Thanks to Konstantin Zaitcev for reporting this and offering a fix.

There is problem with uninstaller.jar content when we use installer jar with "(1)" for example install (1).jar it very often case when we download installer several times.

In this case JarMerge performs replaceAll with "(1)" that treated as regular expression.

Thanks to Konstantin Zaitcev for reporting this and offering a fix.

The "Add"/"Remove" button labels for custom input fields on a UserInputPanel should be translated.

Adding the basic translations I know (english, german, czech) and asking the community to add translations for more languages.

For console as well as GUI installers there is a few complaints about the layout of the new "custom" type input field:

• GUI: the button labels of "add"/"remove" should be "Add"/"Remove".
• GUI: The insets of the "Add"/"Remove" buttons against the input rows should be increased.
• Console: There is no user-friendly recognition which are the rows available for inputs, rather add row numbers or some indentations.
• Console: It should be possible to directly edit specific rows without redisplaying and navigating all valid rows before.

TODO: There is still to be solved the translations of the user tests of the custom field for both installer types.

Currently, the title for warning and error messages is not shown in console installations. This makes ot hard for the user know what's going on.

There should be a more user-firendly console interface as equivalent to error and warning messageboxes in Swing installers.

Example of the current behavior:
There is just shown the warning message of a panel validator:

Could not connect to broker URL: tcp://localhost:7000. Reason: java.net.ConnectException: Connection refused
Enter O for OK, C to Cancel:

Example of the desired behavior:
There should eb also shown the title and some horizontal lines as separators to recognize a messagebox equivalent:

------------------------------------------------------------------------------------------------------------
Validation failed - continuing installation
Could not connect to broker URL: tcp://localhost:7000. Reason: java.net.ConnectException: Connection refused
------------------------------------------------------------------------------------------------------------
Enter O for OK, C to Cancel:

When creating shortcuts from the command line under Linux I receive the following warning. Please find attached the relevant shortcuts file.

Create shortcuts in the XDG-Menu
Enter Y for Yes, N for No:
n
May 11, 2015 3:40:15 PM WARNING: Cannot write to '/usr/share/applications'
java.io.IOException: Permission denied
at java.io.UnixFileSystem.createFileExclusively(Native Method)
at java.io.File.createNewFile(File.java:1006)
at java.io.File.createTempFile(File.java:1989)
at com.izforge.izpack.panels.shortcut.ShortcutPanelLogic.isWritable(ShortcutPanelLogic.java:760)
at com.izforge.izpack.panels.shortcut.ShortcutPanelLogic.initUserType(ShortcutPanelLogic.java:675)
at com.izforge.izpack.panels.shortcut.ShortcutConsolePanel.chooseEffectedUsers(ShortcutConsolePanel.java:198)
at com.izforge.izpack.panels.shortcut.ShortcutConsolePanel.run(ShortcutConsolePanel.java:144)
at com.izforge.izpack.installer.console.ConsoleInstallAction.run(ConsoleInstallAction.java:64)
at com.izforge.izpack.installer.console.ConsolePanels.switchPanel(ConsolePanels.java:82)
at com.izforge.izpack.installer.console.ConsolePanels.switchPanel(ConsolePanels.java:36)
at com.izforge.izpack.installer.panel.AbstractPanels.switchPanel(AbstractPanels.java:504)
at com.izforge.izpack.installer.panel.AbstractPanels.next(AbstractPanels.java:251)
at com.izforge.izpack.installer.panel.AbstractPanels.next(AbstractPanels.java:231)
at com.izforge.izpack.installer.console.ConsoleInstaller.run(ConsoleInstaller.java:183)
at com.izforge.izpack.installer.bootstrap.Installer.launchConsoleInstaller(Installer.java:262)
at com.izforge.izpack.installer.bootstrap.Installer.launchInstall(Installer.java:225)
at com.izforge.izpack.installer.bootstrap.Installer.start(Installer.java:193)
at com.izforge.izpack.installer.bootstrap.Installer.main(Installer.java:72)

There is a weird error when having a DataValidator emitting a Status.WARNING instead of error, but just for console installations. The Swing installer behaves like expected. In the console installation, the user must exactly three times confirm OK to get to the next panel.

I injected generating a stacktrace to figure out what is repeating here

Message broker connection

--> Row 1: URL: [tcp://localhost:7000]
Enter the row number (1..1) to edit, 2 to continue, 3 to redisplay, 4 to add a row
2
Could not connect to broker URL: tcp://localhost:7000. Reason: java.net.ConnectException: Connection refused
Enter O for OK, C to Cancel:
O
java.lang.Exception: O
        at com.izforge.izpack.core.handler.ConsolePrompt.confirm(ConsolePrompt.java:162)
        at com.izforge.izpack.core.handler.PromptUIHandler.emitWarning(PromptUIHandler.java:89)
        at com.izforge.izpack.installer.panel.AbstractPanelView.isWarningValid(AbstractPanelView.java:514)
        at com.izforge.izpack.installer.panel.AbstractPanelView.isValid(AbstractPanelView.java:486)
        at com.izforge.izpack.installer.panel.AbstractPanelView.isValid(AbstractPanelView.java:451)
        at com.izforge.izpack.installer.panel.AbstractPanelView.validateData(AbstractPanelView.java:417)
        at com.izforge.izpack.installer.panel.AbstractPanelView.isValid(AbstractPanelView.java:261)
        at com.izforge.izpack.installer.console.AbstractConsolePanel.promptEndPanel(AbstractConsolePanel.java:88)
        at com.izforge.izpack.panels.userinput.UserInputConsolePanel.run(UserInputConsolePanel.java:192)
        at com.izforge.izpack.installer.console.ConsoleInstallAction.run(ConsoleInstallAction.java:64)
        at com.izforge.izpack.installer.console.ConsolePanels.switchPanel(ConsolePanels.java:82)
        at com.izforge.izpack.installer.console.ConsolePanels.switchPanel(ConsolePanels.java:1)
        at com.izforge.izpack.installer.panel.AbstractPanels.switchPanel(AbstractPanels.java:509)
        at com.izforge.izpack.installer.panel.AbstractPanels.next(AbstractPanels.java:254)
        at com.izforge.izpack.installer.panel.AbstractPanels.next(AbstractPanels.java:234)
        at com.izforge.izpack.installer.console.ConsoleInstaller.run(ConsoleInstaller.java:183)
        at com.izforge.izpack.installer.bootstrap.Installer.launchConsoleInstaller(Installer.java:262)
        at com.izforge.izpack.installer.bootstrap.Installer.launchInstall(Installer.java:225)
        at com.izforge.izpack.installer.bootstrap.Installer.start(Installer.java:193)
        at com.izforge.izpack.installer.bootstrap.Installer.main(Installer.java:72)

Press 1 to continue, 2 to quit, 3 to redisplay
1
Could not connect to broker URL: tcp://localhost:7000. Reason: java.net.ConnectException: Connection refused
Enter O for OK, C to Cancel:
O
java.lang.Exception: O
        at com.izforge.izpack.core.handler.ConsolePrompt.confirm(ConsolePrompt.java:162)
        at com.izforge.izpack.core.handler.PromptUIHandler.emitWarning(PromptUIHandler.java:89)
        at com.izforge.izpack.installer.panel.AbstractPanelView.isWarningValid(AbstractPanelView.java:514)
        at com.izforge.izpack.installer.panel.AbstractPanelView.isValid(AbstractPanelView.java:486)
        at com.izforge.izpack.installer.panel.AbstractPanelView.isValid(AbstractPanelView.java:451)
        at com.izforge.izpack.installer.panel.AbstractPanelView.validateData(AbstractPanelView.java:417)
        at com.izforge.izpack.installer.panel.AbstractPanelView.isValid(AbstractPanelView.java:261)
        at com.izforge.izpack.installer.console.ConsolePanels.switchPanel(ConsolePanels.java:87)
        at com.izforge.izpack.installer.console.ConsolePanels.switchPanel(ConsolePanels.java:1)
        at com.izforge.izpack.installer.panel.AbstractPanels.switchPanel(AbstractPanels.java:509)
        at com.izforge.izpack.installer.panel.AbstractPanels.next(AbstractPanels.java:254)
        at com.izforge.izpack.installer.panel.AbstractPanels.next(AbstractPanels.java:234)
        at com.izforge.izpack.installer.console.ConsoleInstaller.run(ConsoleInstaller.java:183)
        at com.izforge.izpack.installer.bootstrap.Installer.launchConsoleInstaller(Installer.java:262)
        at com.izforge.izpack.installer.bootstrap.Installer.launchInstall(Installer.java:225)
        at com.izforge.izpack.installer.bootstrap.Installer.start(Installer.java:193)
        at com.izforge.izpack.installer.bootstrap.Installer.main(Installer.java:72)
Could not connect to broker URL: tcp://localhost:7000. Reason: java.net.ConnectException: Connection refused
Enter O for OK, C to Cancel:
O
java.lang.Exception: O
        at com.izforge.izpack.core.handler.ConsolePrompt.confirm(ConsolePrompt.java:162)
        at com.izforge.izpack.core.handler.PromptUIHandler.emitWarning(PromptUIHandler.java:89)
        at com.izforge.izpack.installer.panel.AbstractPanelView.isWarningValid(AbstractPanelView.java:514)
        at com.izforge.izpack.installer.panel.AbstractPanelView.isValid(AbstractPanelView.java:486)
        at com.izforge.izpack.installer.panel.AbstractPanelView.isValid(AbstractPanelView.java:451)
        at com.izforge.izpack.installer.panel.AbstractPanelView.validateData(AbstractPanelView.java:417)
        at com.izforge.izpack.installer.panel.AbstractPanelView.isValid(AbstractPanelView.java:261)
        at com.izforge.izpack.installer.panel.AbstractPanelView.isValid(AbstractPanelView.java:239)
        at com.izforge.izpack.installer.panel.AbstractPanels.executeValidationActions(AbstractPanels.java:597)
        at com.izforge.izpack.installer.panel.AbstractPanels.isValid(AbstractPanels.java:177)
        at com.izforge.izpack.installer.panel.AbstractPanels.next(AbstractPanels.java:249)
        at com.izforge.izpack.installer.panel.AbstractPanels.next(AbstractPanels.java:234)
        at com.izforge.izpack.installer.console.ConsoleInstaller.run(ConsoleInstaller.java:183)
        at com.izforge.izpack.installer.bootstrap.Installer.launchConsoleInstaller(Installer.java:262)
        at com.izforge.izpack.installer.bootstrap.Installer.launchInstall(Installer.java:225)
        at com.izforge.izpack.installer.bootstrap.Installer.start(Installer.java:193)
        at com.izforge.izpack.installer.bootstrap.Installer.main(Installer.java:72)

  [x] Include optional pack 'Application'
Enter Y for Yes, N for No:
...

Pressing CTRL-C when waiting for user input lets a console installation fail with the following output:

jline.console.UserInterruptException
        at jline.console.ConsoleReader.readLine(ConsoleReader.java:2681)
        at jline.console.ConsoleReader.readLine(ConsoleReader.java:2269)
        at jline.console.ConsoleReader.readLine(ConsoleReader.java:2257)
        at com.izforge.izpack.util.Console.readLine(Console.java:92)
        at com.izforge.izpack.util.Console.prompt(Console.java:182)
        at com.izforge.izpack.panels.userinput.console.custom.ConsoleCustomField.display(ConsoleCustomField.java:199)
        at com.izforge.izpack.panels.userinput.UserInputConsolePanel.run(UserInputConsolePanel.java:177)
        at com.izforge.izpack.installer.console.ConsoleInstallAction.run(ConsoleInstallAction.java:64)
        at com.izforge.izpack.installer.console.ConsolePanels.switchPanel(ConsolePanels.java:82)
        at com.izforge.izpack.installer.console.ConsolePanels.switchPanel(ConsolePanels.java:1)
        at com.izforge.izpack.installer.panel.AbstractPanels.switchPanel(AbstractPanels.java:509)
        at com.izforge.izpack.installer.panel.AbstractPanels.next(AbstractPanels.java:254)
        at com.izforge.izpack.installer.panel.AbstractPanels.next(AbstractPanels.java:234)
        at com.izforge.izpack.installer.console.ConsoleInstaller.run(ConsoleInstaller.java:183)
        at com.izforge.izpack.installer.bootstrap.Installer.launchConsoleInstaller(Installer.java:262)
        at com.izforge.izpack.installer.bootstrap.Installer.launchInstall(Installer.java:225)
        at com.izforge.izpack.installer.bootstrap.Installer.start(Installer.java:193)
        at com.izforge.izpack.installer.bootstrap.Installer.main(Installer.java:72)

[ Console installation FAILED! ]

Second example from the packs panel:

jline.console.UserInterruptException
        at jline.console.ConsoleReader.readLine(ConsoleReader.java:2681)
        at jline.console.ConsoleReader.readLine(ConsoleReader.java:2269)
        at jline.console.ConsoleReader.readLine(ConsoleReader.java:2257)
        at com.izforge.izpack.util.Console.readLine(Console.java:92)
        at com.izforge.izpack.util.Console.prompt(Console.java:401)
        at com.izforge.izpack.util.Console.prompt(Console.java:384)
        at com.izforge.izpack.util.Console.prompt(Console.java:431)
        at com.izforge.izpack.core.handler.ConsolePrompt.confirm(ConsolePrompt.java:206)
        at com.izforge.izpack.api.handler.AbstractPrompt.confirm(AbstractPrompt.java:148)
        at com.izforge.izpack.panels.packs.PacksConsolePanel.askUser(PacksConsolePanel.java:202)
        at com.izforge.izpack.panels.packs.PacksConsolePanel.drawHelper(PacksConsolePanel.java:160)
        at com.izforge.izpack.panels.packs.PacksConsolePanel.run(PacksConsolePanel.java:108)
        at com.izforge.izpack.installer.console.ConsoleInstallAction.run(ConsoleInstallAction.java:64)
        at com.izforge.izpack.installer.console.ConsolePanels.switchPanel(ConsolePanels.java:82)
        at com.izforge.izpack.installer.console.ConsolePanels.switchPanel(ConsolePanels.java:1)
        at com.izforge.izpack.installer.panel.AbstractPanels.switchPanel(AbstractPanels.java:509)
        at com.izforge.izpack.installer.panel.AbstractPanels.next(AbstractPanels.java:254)
        at com.izforge.izpack.installer.panel.AbstractPanels.next(AbstractPanels.java:234)
        at com.izforge.izpack.installer.console.ConsoleInstaller.run(ConsoleInstaller.java:183)
        at com.izforge.izpack.installer.bootstrap.Installer.launchConsoleInstaller(Installer.java:262)
        at com.izforge.izpack.installer.bootstrap.Installer.launchInstall(Installer.java:225)
        at com.izforge.izpack.installer.bootstrap.Installer.start(Installer.java:193)
        at com.izforge.izpack.installer.bootstrap.Installer.main(Installer.java:72)

[ Console installation FAILED! ]

This exception should be caught and another message should be shown:

[ Console installation cancelled by user ]

The message

[ Console installation FAILED! ]

comes also (without a stacktrace) on choosing Quit in a console installation, should be the replaced by the message above as well.

Installers containing at least two packs with parsable and executable files fail with FileNotFoundException in the second pack if the first pack uses a executable with stage postinstall.

Exception in thread "IzPack - Unpacker thread" java.lang.ClassCastException: java.io.FileNotFoundException cannot be cast to com.izforge.izpack.api.exception.IzPackException
        at com.izforge.izpack.installer.unpacker.UnpackerBase.unpack(UnpackerBase.java:273)
        at com.izforge.izpack.installer.unpacker.UnpackerBase.run(UnpackerBase.java:235)
        at java.lang.Thread.run(Unknown Source)

Provided a definition like this:

    <variable name="db.name" value="${db.url}" checkonce="true" condition="NotInstall+haveDatabaseURL+useMssql">
      <filters>
        <regex regexp="jdbc:jtds:sqlserver://[^:]+:\d+.*;DatabaseName=([^;]*)" select="\1" />
      </filters>
    </variable>
    <variable name="db.name" value="${db.url}" checkonce="true" condition="NotInstall+haveDatabaseURL+useMssql">
      <filters>
        <regex regexp="jdbc:jtds:sqlserver://[^:]+:\d+/([^:;]+)" select="\1" />
      </filters>
    </variable>

currently the first of the above two definitions withing <dynamicvariables> is ignored. A warning comes up during compiling:
Variable definition 'db.name' will be overwritten.

The currently rule for uniqueness of a dynamic variable is bound to comparing just its name and conditionid.

This is not correct. Both definitions should apply. If one of them results in a null value the one providing a non-null value should provide the final value.

Mostly a short time after fresh IzPack snapshot deployments I've noticed build failures when using the special packaing type izpack-jar in the POM.

There are appearing errors like this:

10:04:58 [ERROR] Failed to execute goal org.codehaus.izpack:izpack-maven-plugin:5.0.0-rc5-SNAPSHOT:izpack (default-izpack) on project my-app: Execution default-izpack of goal org.codehaus.izpack:izpack-maven-plugin:5.0.0-rc5-SNAPSHOT:izpack failed: A required class was missing while executing org.codehaus.izpack:izpack-maven-plugin:5.0.0-rc5-SNAPSHOT:izpack: com/izforge/izpack/api/data/Info
10:04:58 [ERROR] -----------------------------------------------------
10:04:58 [ERROR] realm =    plugin>org.codehaus.izpack:izpack-maven-plugin:5.0.0-rc5-SNAPSHOT
10:04:58 [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
10:04:58 [ERROR] urls[0] = file:/var/lib/hudson-slave/maven-repositories/0/org/codehaus/izpack/izpack-maven-plugin/5.0.0-rc5-SNAPSHOT/izpack-maven-plugin-5.0.0-rc5-SNAPSHOT.jar
10:04:58 [ERROR] urls[1] = file:/var/lib/hudson-slave/maven-repositories/0/backport-util-concurrent/backport-util-concurrent/3.1/backport-util-concurrent-3.1.jar
10:04:58 [ERROR] urls[2] = file:/var/lib/hudson-slave/maven-repositories/0/org/codehaus/plexus/plexus-interpolation/1.11/plexus-interpolation-1.11.jar
10:04:58 [ERROR] urls[3] = file:/var/lib/hudson-slave/maven-repositories/0/org/codehaus/plexus/plexus-utils/1.5.15/plexus-utils-1.5.15.jar
10:04:58 [ERROR] urls[4] = file:/var/lib/hudson-slave/maven-repositories/0/org/codehaus/izpack/izpack-compiler/5.0.0-rc5-SNAPSHOT/izpack-compiler-5.0.0-rc5-SNAPSHOT.jar
10:04:58 [ERROR] urls[5] = file:/var/lib/hudson-slave/maven-repositories/0/org/codehaus/izpack/izpack-native/5.0.0-rc5-SNAPSHOT/izpack-native-5.0.0-rc5-SNAPSHOT.jar
10:04:58 [ERROR] urls[6] = file:/var/lib/hudson-slave/maven-repositories/0/org/codehaus/izpack/izpack-panel/5.0.0-rc5-SNAPSHOT/izpack-panel-5.0.0-rc5-SNAPSHOT.jar
10:04:58 [ERROR] urls[7] = file:/var/lib/hudson-slave/maven-repositories/0/org/codehaus/izpack/izpack-util/5.0.0-rc5-SNAPSHOT/izpack-util-5.0.0-rc5-SNAPSHOT.jar
10:04:58 [ERROR] urls[8] = file:/var/lib/hudson-slave/maven-repositories/0/org/jdom/jdom2/2.0.5/jdom2-2.0.5.jar
10:04:58 [ERROR] urls[9] = file:/var/lib/hudson-slave/maven-repositories/0/org/apache/maven/shared/maven-shared-jar/1.1/maven-shared-jar-1.1.jar
10:04:58 [ERROR] urls[10] = file:/var/lib/hudson-slave/maven-repositories/0/org/codehaus/plexus/plexus-digest/1.0/plexus-digest-1.0.jar
10:04:58 [ERROR] urls[11] = file:/var/lib/hudson-slave/maven-repositories/0/org/apache/bcel/bcel/5.2/bcel-5.2.jar
10:04:58 [ERROR] urls[12] = file:/var/lib/hudson-slave/maven-repositories/0/jakarta-regexp/jakarta-regexp/1.4/jakarta-regexp-1.4.jar
10:04:58 [ERROR] urls[13] = file:/var/lib/hudson-slave/maven-repositories/0/commons-collections/commons-collections/3.1/commons-collections-3.1.jar
10:04:58 [ERROR] urls[14] = file:/var/lib/hudson-slave/maven-repositories/0/org/picocontainer/picocontainer/2.14.1/picocontainer-2.14.1.jar
10:04:58 [ERROR] urls[15] = file:/var/lib/hudson-slave/maven-repositories/0/commons-lang/commons-lang/2.6/commons-lang-2.6.jar
10:04:58 [ERROR] urls[16] = file:/var/lib/hudson-slave/maven-repositories/0/commons-cli/commons-cli/1.2/commons-cli-1.2.jar
10:04:58 [ERROR] urls[17] = file:/var/lib/hudson-slave/maven-repositories/0/org/apache/commons/commons-compress/1.3/commons-compress-1.3.jar
10:04:58 [ERROR] urls[18] = file:/var/lib/hudson-slave/maven-repositories/0/jline/jline/2.12/jline-2.12.jar
10:04:58 [ERROR] urls[19] = file:/var/lib/hudson-slave/maven-repositories/0/xpp3/xpp3/1.1.4c/xpp3-1.1.4c.jar
10:04:58 [ERROR] urls[20] = file:/var/lib/hudson-slave/maven-repositories/0/org/java/net/substance/substance/6.0/substance-6.0.jar
10:04:58 [ERROR] urls[21] = file:/var/lib/hudson-slave/maven-repositories/0/org/pushing-pixels/trident/1.2/trident-1.2.jar
10:04:58 [ERROR] urls[22] = file:/var/lib/hudson-slave/maven-repositories/0/org/eclipse/swt/win32/win32/x86/3.3.0-v3346/x86-3.3.0-v3346.jar
10:04:58 [ERROR] urls[23] = file:/var/lib/hudson-slave/maven-repositories/0/net/java/dev/laf-widget/laf-widget/5.0/laf-widget-5.0.jar
10:04:58 [ERROR] urls[24] = file:/var/lib/hudson-slave/maven-repositories/0/asm/asm-all/2.2.3/asm-all-2.2.3.jar
10:04:58 [ERROR] urls[25] = file:/var/lib/hudson-slave/maven-repositories/0/net/java/dev/laf-plugin/laf-plugin/1.1/laf-plugin-1.1.jar
10:04:58 [ERROR] urls[26] = file:/var/lib/hudson-slave/maven-repositories/0/be/cyberelf/nanoxml/lite/2.2.3/lite-2.2.3.jar
10:04:58 [ERROR] urls[27] = file:/var/lib/hudson-slave/maven-repositories/0/com/incors/kunstoff-laf/2.0.2/kunstoff-laf-2.0.2.jar
10:04:58 [ERROR] urls[28] = file:/var/lib/hudson-slave/maven-repositories/0/com/jgoodies/looks/2.2.2/looks-2.2.2.jar
10:04:58 [ERROR] urls[29] = file:/var/lib/hudson-slave/maven-repositories/0/org/codehaus/izpack/izpack-core/5.0.0-rc5-SNAPSHOT/izpack-core-5.0.0-rc5-SNAPSHOT.jar
10:04:58 [ERROR] urls[30] = file:/var/lib/hudson-slave/maven-repositories/0/org/codehaus/izpack/izpack-tools/5.0.0-rc5-SNAPSHOT/izpack-tools-5.0.0-rc5-SNAPSHOT.jar
10:04:58 [ERROR] urls[31] = file:/var/lib/hudson-slave/maven-repositories/0/org/apache/ant/ant/1.9.4/ant-1.9.4.jar
10:04:58 [ERROR] urls[32] = file:/var/lib/hudson-slave/maven-repositories/0/org/apache/ant/ant-launcher/1.9.4/ant-launcher-1.9.4.jar
10:04:58 [ERROR] urls[33] = file:/var/lib/hudson-slave/maven-repositories/0/org/codehaus/izpack/izpack-uninstaller/5.0.0-rc5-SNAPSHOT/izpack-uninstaller-5.0.0-rc5-SNAPSHOT.jar
10:04:58 [ERROR] urls[34] = file:/var/lib/hudson-slave/maven-repositories/0/org/codehaus/izpack/izpack-gui/5.0.0-rc5-SNAPSHOT/izpack-gui-5.0.0-rc5-SNAPSHOT.jar
10:04:58 [ERROR] urls[35] = file:/var/lib/hudson-slave/maven-repositories/0/org/codehaus/izpack/izpack-installer/5.0.0-rc5-SNAPSHOT/izpack-installer-5.0.0-rc5-SNAPSHOT.jar
10:04:58 [ERROR] urls[36] = file:/var/lib/hudson-slave/maven-repositories/0/org/codehaus/izpack/izpack-event/5.0.0-rc5-SNAPSHOT/izpack-event-5.0.0-rc5-SNAPSHOT.jar
10:04:58 [ERROR] urls[37] = file:/var/lib/hudson-slave/maven-repositories/0/org/codehaus/izpack/izpack-api/5.0.0-rc5-SNAPSHOT/izpack-api-5.0.0-rc5-SNAPSHOT.jar
10:04:58 [ERROR] urls[38] = file:/var/lib/hudson-slave/maven-repositories/0/commons-io/commons-io/2.4/commons-io-2.4.jar
10:04:58 [ERROR] Number of foreign imports: 1
10:04:58 [ERROR] import: Entry[import  from realm ClassRealm[project>com.mycompany:my-app:01.02.00-SNAPSHOT, parent: ClassRealm[maven.api, parent: null]]]
10:04:58 [ERROR]
10:04:58 [ERROR] -----------------------------------------------------: com.izforge.izpack.api.data.Info
10:04:58 [ERROR] -> [Help 1]
10:04:58 [ERROR]
10:04:58 [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
10:04:58 [ERROR] Re-run Maven using the -X switch to enable full debug logging.
10:04:58 [ERROR]
10:04:58 [ERROR] For more information about the errors and possible solutions, please read the following articles:
10:04:58 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginContainerException
10:04:58 [ERROR]

This happens on CI buildsystems like Hudson and during local builds accessing a repository manager as well.

On Unix, when validating user inputs, in case of validation errors or warnings the installer opens a messagebox with a focused 'Close' button, but pressing ENTER doesn't close it, just ESC, SPACE or clicking it directly close these messageboxes.

This is specific to the Look and Feel. Activate/override the "Button.defaultButtonFollowsFocus" setting in general for all L&F.

com.izforge.izpack.panels.userinput.validator.HostAddressValidator does not work as expected it gives errors always even if the port is not in use.

On opening a user input panel during a Swing-based installation, there is not automatically focused the first valid input field. Instead, the user must navigate or click on it to do any input.

I have a pack in my install.xml containing file elements with the override attribute set to false. My understanding was that after the first install, the file would never be overridden for subsequent installs. When I run the installer, files are overridden as if the attribute was set to the default value update. I was able to verify this by manually changing the modified date on a single file and running the installer. The file that was changed was the only one that was overridden in the pack.

When defining a installer, some of the configuration is evaluated during install. So you can use variables for this attributes.

Other attributes are evaluated during compile. The dynamic variables can not be used at this stage, because they can evaluated only during install. But the static variables are available during compile also and could be useful for customized builds.

Some attributes did accept static variables since 2010, others were added within IZPACK-1234.

There still may be attributes were static variables would be useful. It could be a reasonable idea to resolve static variables in the XML-parser, so that variables could be used in all definitions without special handling on the sprecific attribute.

Any comments on this?

Referring to http://docs.codehaus.org/display/IZPACK/Adding+a+set+of+files a <fileset> must have a "dir"-attribute and may have a "file"-attribut which is relativ to the "dir".

But the source code in CompilerConfig.java behaves different:

1. "file" is not relative to "dir"
2. "dir" is mandatory in line 3164, but it should be optional in lines 3165-3189)
3. If "dir" should be mandatory, "file" has to be relative to dir.

Either source or documentation should be adapted. Which variant should survive?

When defining a pack, you can include files with three different definitions:

1. <singlefile> for inclusion of a single file to a target file
2. <file> for inclusion of a single file to a target directory
3. <fileset> for inclusion of a set of files to a target directory

See the following definition as the starting point for the further investigations:

  <packs>
    <pack name="singlefile" required="false" >
      <description>including a singlefile</description>
      <singlefile target="${INSTALL_PATH}/singlefile/file1.txt" src="files/file1.txt" />
    </pack>
    <pack name="file" required="false" >
      <description>including a file</description>
      <file targetdir="${INSTALL_PATH}/file" src="files/file1.txt" />
    </pack>
    <pack name="fileset" required="false" >
      <description>including a fileset</description>
      <fileset targetdir="${INSTALL_PATH}/fileset" dir="files" >
        <include name="file1.txt" />
      </fileset>
    </pack>
  </packs>

Inside the "target" / "targetdir" attributs there are variables used already. This variables will be computated during install time later.

It may helpful to use variables or properties for defining the source also, because your build process could produce some artifacts with some variable names (things like a version or a varianbt for example). Therefore variables should be allowed for the "src" and "name"-attributes:

• Using dynamic variables would not be a reasonable idea, because the value will not be available on compilation, but only later during installation, which is too late.
• Using static variables (or properties) should be possible. The values are known on compilation already.

So the following definition should work as well:

  <variables>
    <variable name="srcDir" value="files" />
    <variable name="var" value="file2.txt" />
  </variables>
  <packs>
    <pack name="singlefile" required="false" >
      <description>including a singlefile</description>
      <singlefile target="${INSTALL_PATH}/singlefile/file1.txt" src="files/file1.txt" />
      <singlefile target="${INSTALL_PATH}/singlefile/${var}" src="files/${var}" />
    </pack>
    <pack name="file" required="false" >
      <description>including a file</description>
      <file targetdir="${INSTALL_PATH}/file" src="files/file1.txt" />
      <file targetdir="${INSTALL_PATH}/file" src="files/${var}" />
    </pack>
    <pack name="fileset" required="false" >
      <description>including a fileset</description>
      <fileset targetdir="${INSTALL_PATH}/fileset" dir="${srcDir}" >
        <include name="file1.txt" />
        <include name="${var}" />
      </fileset>
    </pack>
    <pack name="fileset2" required="false" >
      <description>including a fileset with a single file</description>
      <fileset targetdir="${INSTALL_PATH}/fileset2" dir="${srcDir}" file="files/${var}" >
         <!-- see https://jira.codehaus.org/browse/IZPACK-1235 for inconsistence of "dir and "file" -->
      </fileset>
    </pack>
  </packs>

But the 3 elements behave different when using variables for the source of the file:

• <singlefile>: both file1.txt and file2.txt do work – fine!
• <file> does complain during compile: "Source file files\${var} not found"
• <fileset> the <include> does work, but the dir="${srcDir}" does not find the source dir.

Custom pack validator class cannot be loaded when running an installer, built with maven, due to a ClassNotFoundException: com.izfore.izpack.panels.treepacks.PackValidator. The problem is that the PackValidator class is not included in the generated installer jar. This worked in IzPack version 4.3. However, the PackValidator class is in com.izforge.izpack.installer package in that version.

PacksConsolePanel prints the id of the packs in console mode, not the localized pack names.

It will be helpful that the packs and description will printed localized, as the user has in the packlang.xml, not only the id defined in install.xml

If there occur Ant build failures in AntActionInstallerListener they are handled poorly at the moment. In each case, the installation fails with a messagebox containing the complete error trace not very useful for people just using an installer.

The error handling should be enhanced to the following possibilities:

• Hide the Ant stacktrace from the user or open it optionally
  Ant build stacktraces can be still seen in the AntAction log file.
• info, warning and error level

When trying to install via command line using the current 5.0.0.-rc5-Snapshot (izpack-installer-5.0.0-rc5-20150227.180304-16.jar) the installer is starting to unpack the files, a error comes up saying: 'Can't find named resource: packsLang.xml & packsLang.xml_eng.

The installation is interrupted here.

When defining dynamic variables you can use filters to modify the value. Currently only a regex and a location filter are available.

I have a use case, where I need to have a variable with all lowercase, independent ot the input of the user. The regex filter is not able to handle this, because the Java regex-functionality does not include a case-conversion like available in Perl with \l.

So I want to implement a lowercase and uppercase Filter.

In a definition like

    <variable name="var1" value="{$var2} >
      <filters>
        <unkownFilter />
      </filters>
    </variable>

the unknown filter is silently ignored. Should be handled as an severe error, because Installer will not behave like intended.

A NPE occurs during performing the ConfigurationInstallerListener when there is just a toFile attribute defined in the ConfigurationActionSpec.xml resource, without the patchFile attribute.

Feb 27, 2015 6:39:22 PM SEVERE: java.lang.NullPointerException
com.izforge.izpack.api.exception.InstallerException: java.lang.NullPointerException
        at com.izforge.izpack.event.ConfigurationInstallerListener.performAllActions(ConfigurationInstallerListener.java:357)
        at com.izforge.izpack.event.ConfigurationInstallerListener.afterPack(ConfigurationInstallerListener.java:261)
        at com.izforge.izpack.installer.event.InstallerListeners.afterPack(InstallerListeners.java:287)
        at com.izforge.izpack.installer.unpacker.UnpackerBase.unpack(UnpackerBase.java:412)
        at com.izforge.izpack.installer.unpacker.UnpackerBase.unpack(UnpackerBase.java:251)
        at com.izforge.izpack.installer.unpacker.UnpackerBase.run(UnpackerBase.java:233)
        at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.NullPointerException
        at com.izforge.izpack.util.config.SingleOptionFileTask.writeConfigurable(SingleOptionFileTask.java:127)
        at com.izforge.izpack.util.config.SingleConfigurableTask.execute(SingleConfigurableTask.java:217)
        at com.izforge.izpack.event.ConfigurationActionTask.execute(ConfigurationActionTask.java:71)
        at com.izforge.izpack.event.ConfigurationAction.performInstallAction(ConfigurationAction.java:59)
        at com.izforge.izpack.event.ConfigurationInstallerListener.performAllActions(ConfigurationInstallerListener.java:353)
        ... 6 more

The ConfigurationInstallerListener can be used to add, change or remove entries from e.g. propertiy-files. Removing entries does not work as supposed when a entry should be removed regardless of it's value.

<izpack:configurationactions version="5.0"
      xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
      xmlns:izpack="https://izpack.github.io/schema/configurationactions"
      xsi:schemaLocation="https://izpack.github.io/schema/configurationactions
      https://izpack.github.io/schema/5.0/izpack-configurationactions-5.0.xsd">
  <pack name="Demo" >
    <configurationaction order="afterpack" >
        <configurable tofile="demo.properties" type="options">
        <entry key="key1" operation="remove" />
        <entry key="key2" operation="remove" lookupType="regexp" value=".*" />
      </configurable>
    </configurationaction>
  </pack>
</izpack:configurationactions>

"key2" will be removed, but "key1" isn't removed, but should be so also.

I've tested in 5.0.0-rc5-SNAPSHOT, but the problem should exist since 2010.

When including zip file with folders the compile gives below errors any way we can avoid this? or are there any solutions

Unable to create directory v2.4.4\plugins
com.izforge.izpack.api.exception.CompilerException: Unable to create directory v2.4.4\plugins
at com.izforge.izpack.compiler.CompilerConfig.processFileChildren(CompilerConfig.java:1123)
at com.izforge.izpack.compiler.CompilerConfig.addPacksSingle(CompilerConfig.java:798)
at com.izforge.izpack.compiler.CompilerConfig.addPacks(CompilerConfig.java:697)
at com.izforge.izpack.compiler.CompilerConfig.executeCompiler(CompilerConfig.java:327)
at com.izforge.izpack.compiler.bootstrap.CompilerLauncher.main(CompilerLauncher.java:52)
Caused by: java.io.IOException: Unable to create directory v2.4.4\plugins
at org.apache.commons.io.FileUtils.forceMkdir(FileUtils.java:2384)
at com.izforge.izpack.compiler.CompilerConfig.addArchiveContent(CompilerConfig.java:1510)
at com.izforge.izpack.compiler.CompilerConfig.processFileChildren(CompilerConfig.java:1106)
... 4 more

Hi,

After cloning the git repository and as per instruction ran 'mvn install' but it gives below error

Concurrency config is parallel='both', perCoreThreadCount=true, threadCount=4, useUnlimitedThreads=false
Running com.izforge.izpack.util.config.base.RegTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.562 sec
Running com.izforge.izpack.util.config.base.spi.IniParserTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec
Running com.izforge.izpack.util.DefaultTargetPlatformFactoryTest
unix,version=null,arch=unknown,symbolicName=null,javaVersion=null=com.izforge.izpack.util.DefaultTargetPlatformFactoryTest$Un
ixA

linux,version=null,arch=unknown,symbolicName=null,javaVersion=null=com.izforge.izpack.util.DefaultTargetPlatformFactoryTest$L
inuxA

windows,version=null,arch=unknown,symbolicName=null,javaVersion=null=com.izforge.izpack.util.DefaultTargetPlatformFactoryTest
$WinA

debian_linux,version=null,arch=unknown,symbolicName=null,javaVersion=null=com.izforge.izpack.util.DefaultTargetPlatformFactor
yTest$DebianA

windows,version=6.1,arch=unknown,symbolicName=WINDOWS_7,javaVersion=null=com.izforge.izpack.util.DefaultTargetPlatformFactory
Test$Win7

windows,version=null,arch=x64,symbolicName=null,javaVersion=null=com.izforge.izpack.util.DefaultTargetPlatformFactoryTest$Win
X64

windows,version=null,arch=x86,symbolicName=null,javaVersion=null=com.izforge.izpack.util.DefaultTargetPlatformFactoryTest$Win
X86

windows,version=6.1,arch=x64,symbolicName=WINDOWS_7,javaVersion=null=com.izforge.izpack.util.DefaultTargetPlatformFactoryTest
$Win7X64

Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.009 sec
Running com.izforge.izpack.util.JVMHelperTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.005 sec
Running com.izforge.izpack.util.OsConstraintHelperTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.02 sec
Running com.izforge.izpack.util.PlatformModelMatcherTest
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 sec
Running com.izforge.izpack.util.PrivilegedRunnerTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.01 sec
Running com.izforge.izpack.util.config.SingleConfigurableTaskTest
Feb 23, 2015 4:39:41 PM com.izforge.izpack.util.config.SingleIniFileTask readSourceConfigurable
WARNING: INI file D:\Sumeet\Wawanesa\PRASE%20Build%20POC\IzPack\SourceCode\izpack\izpack-util\target\test-classes\com\izforge
\izpack\util\config\oldversion.ini to patch from could not be found, no patches will be applied

+++ C:\Users\sumeetc\AppData\Local\Temp\junit3063824709023317607\to.ini +++

+++ D:\Sumeet\Wawanesa\PRASE%20Build%20POC\IzPack\SourceCode\izpack\izpack-util\target\test-classes\com\izforge\izpack\util\c
onfig\expected_after_merge.ini +++

java.io.FileNotFoundException: D:\Sumeet\Wawanesa\PRASE%20Build%20POC\IzPack\SourceCode\izpack\izpack-util\target\test-classe
s\com\izforge\izpack\util\config\expected_after_merge.ini (The system cannot find the path specified)

at java.io.FileInputStream.open(Native Method)

at java.io.FileInputStream.<init>(FileInputStream.java:120)

at java.io.FileReader.<init>(FileReader.java:55)

at com.izforge.izpack.util.config.SingleConfigurableTaskTest.printFileContent(SingleConfigurableTaskTest.java:156)

at com.izforge.izpack.util.config.SingleConfigurableTaskTest.testIniCommentsAtEnd(SingleConfigurableTaskTest.java:144
)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

at java.lang.reflect.Method.invoke(Method.java:597)

at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)

at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)

at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)

at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)

at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:46)

at org.junit.rules.RunRules.evaluate(RunRules.java:18)

at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)

at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)

at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)

at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)

at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)

at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)

at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)

at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)

at org.junit.runners.ParentRunner.run(ParentRunner.java:300)

at org.junit.runners.Suite.runChild(Suite.java:128)

at org.junit.runners.Suite.runChild(Suite.java:24)

at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)

at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)

at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)

at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)

at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)

at org.junit.runners.ParentRunner.run(ParentRunner.java:300)

at org.junit.runner.JUnitCore.run(JUnitCore.java:157)

at org.junit.runner.JUnitCore.run(JUnitCore.java:136)

at org.junit.runner.JUnitCore.run(JUnitCore.java:127)

at org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:51)

at org.apache.maven.surefire.junitcore.JUnitCoreProvider.invoke(JUnitCoreProvider.java:108)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

at java.lang.reflect.Method.invoke(Method.java:597)

at org.apache.maven.surefire.booter.ProviderFactory$ClassLoaderProxy.invoke(ProviderFactory.java:103)

at com.sun.proxy.$Proxy0.invoke(Unknown Source)

at org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(SurefireStarter.java:150)

at org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcess(SurefireStarter.java:91)

at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:69)

Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1,201,560.811 sec <<< FAILURE!
Running com.izforge.izpack.util.xmlmerge.XmlMergeTest
Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.118 sec <<< FAILURE!

Results :

Failed tests:
testIniCommentsAtEnd(com.izforge.izpack.util.config.SingleConfigurableTaskTest): expected:<false> but was:<true>

Tests in error:
testMergeFilesWithXPathTagMatcherReplace2Files(com.izforge.izpack.util.xmlmerge.XmlMergeTest)

Tests run: 22, Failures: 1, Errors: 1, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] IzPack parent ...................................... SUCCESS [ 1.963 s]
[INFO] IzPack native module parent ........................ SUCCESS [ 0.299 s]
[INFO] IzPack native module ............................... SUCCESS [ 0.943 s]
[INFO] IzPack tools module ................................ SUCCESS [ 0.584 s]
[INFO] IzPack api module .................................. SUCCESS [ 2.046 s]
[INFO] IzPack util module ................................. FAILURE [ 23.488 s]
[INFO] IzPack test commons module ......................... SKIPPED
[INFO] IzPack core module ................................. SKIPPED
[INFO] IzPack gui module .................................. SKIPPED
[INFO] IzPack installer module ............................ SKIPPED
[INFO] IzPack panel module ................................ SKIPPED
[INFO] IzPack event module ................................ SKIPPED
[INFO] IzPack uninstaller module .......................... SKIPPED
[INFO] IzPack compiler module ............................. SKIPPED
[INFO] IzPack Maven Plugin ................................ SKIPPED
[INFO] IzPack ant module .................................. SKIPPED
[INFO] IzPack wrapper module .............................. SKIPPED
[INFO] IzPack dist module ................................. SKIPPED
[INFO] IzPack install/uninstall test listeners ............ SKIPPED
[INFO] IzPack test module ................................. SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 29.957 s
[INFO] Finished at: 2015-02-23T16:40:02-05:00
[INFO] Final Memory: 21M/349M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.7.2:test (default-test) on project izpack-uti
l: There are test failures.
[ERROR]
[ERROR] Please refer to D:\Sumeet\Wawanesa\PRASE Build POC\IzPack\SourceCode\izpack\izpack-util\target\surefire-reports for t
he individual test results.
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin
:2.7.2:test (default-test) on project izpack-util: There are test failures.

Please refer to D:\Sumeet\Wawanesa\PRASE Build POC\IzPack\SourceCode\izpack\izpack-util\target\surefire-reports for the indiv
idual test results.
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:
51)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:355)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:216)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:160)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoFailureException: There are test failures.

Please refer to D:\Sumeet\Wawanesa\PRASE Build POC\IzPack\SourceCode\izpack\izpack-util\target\surefire-reports for the indiv
idual test results.
at org.apache.maven.plugin.surefire.SurefireHelper.reportExecution(SurefireHelper.java:74)
at org.apache.maven.plugin.surefire.SurefirePlugin.execute(SurefirePlugin.java:642)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
... 19 more
[ERROR]
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :izpack-util
D:\Sumeet\Wawanesa\PRASE Build POC\IzPack\SourceCode\izpack>

An IzPack installer loads currently all custom classes in advance before checking the Java version defined by the optional tag like this:

<javaversion>1.7</javaversion>

For example, if the installer is launched in JRE 6, but some libraries imported by <jar> are compiled using JDK 7 the installer fails on starting with the following stacktrace:

Nov 11, 2014 3:59:31 PM INFO: Logging initialized at level 'INFO'
Nov 11, 2014 3:59:31 PM INFO: Commandline arguments:
Nov 11, 2014 3:59:32 PM INFO: Detected platform: windows,version=6.2,arch=x64,sy
mbolicName=WINDOWS_8,javaVersion=1.6.0_37
Exception in thread "main" java.lang.UnsupportedClassVersionError: com/github/sa
rdine/Sardine : Unsupported major.minor version 51.0
        at java.lang.ClassLoader.defineClass1(Native Method)
        at java.lang.ClassLoader.defineClassCond(Unknown Source)
        at java.lang.ClassLoader.defineClass(Unknown Source)
        at java.security.SecureClassLoader.defineClass(Unknown Source)
        at java.net.URLClassLoader.defineClass(Unknown Source)
        at java.net.URLClassLoader.access$000(Unknown Source)
        at java.net.URLClassLoader$1.run(Unknown Source)
        at java.security.AccessController.doPrivileged(Native Method)
        at java.net.URLClassLoader.findClass(Unknown Source)
        at java.lang.ClassLoader.loadClass(Unknown Source)
        at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source)
        at java.lang.ClassLoader.loadClass(Unknown Source)
        at java.lang.Class.getDeclaredConstructors0(Native Method)
        at java.lang.Class.privateGetDeclaredConstructors(Unknown Source)
        at java.lang.Class.getDeclaredConstructors(Unknown Source)
        at org.picocontainer.injectors.ConstructorInjector$3.run(ConstructorInjector.java:409)
        at org.picocontainer.injectors.ConstructorInjector$3.run(ConstructorInjector.java:407)
        at java.security.AccessController.doPrivileged(Native Method)
        at org.picocontainer.injectors.ConstructorInjector.getConstructors(ConstructorInjector.java:407)
        at org.picocontainer.injectors.ConstructorInjector.getSortedMatchingConstructors(ConstructorInjector.java:383)
        at org.picocontainer.injectors.ConstructorInjector.getGreediestSatisfiableConstructor(ConstructorInjector.java:134)
        at org.picocontainer.injectors.ConstructorInjector.getGreediestSatisfiableConstructor(ConstructorInjector.java:112)
        at org.picocontainer.injectors.ConstructorInjector.access$100(ConstructorInjector.java:52)
        at org.picocontainer.injectors.ConstructorInjector$1.run(ConstructorInjector.java:337)
        at org.picocontainer.injectors.AbstractInjector$ThreadLocalCyclicDependencyGuard.observe(AbstractInjector.java:272)
        at org.picocontainer.injectors.ConstructorInjector.getComponentInstance(ConstructorInjector.java:370)
        at org.picocontainer.behaviors.AbstractBehavior.getComponentInstance(AbstractBehavior.java:64)
        at org.picocontainer.behaviors.Stored.getComponentInstance(Stored.java:91)
        at org.picocontainer.DefaultPicoContainer.getInstance(DefaultPicoContainer.java:692)
        at org.picocontainer.DefaultPicoContainer.getComponent(DefaultPicoContainer.java:646)
        at org.picocontainer.DefaultPicoContainer.getComponent(DefaultPicoContainer.java:671)
        at com.izforge.izpack.core.container.AbstractContainer.getComponent(AbstractContainer.java:131)
        at com.izforge.izpack.core.factory.DefaultObjectFactory.create(DefaultObjectFactory.java:74)
        at com.izforge.izpack.core.factory.DefaultObjectFactory.create(DefaultObjectactory.java:102)
        at com.izforge.izpack.installer.container.impl.CustomDataLoader.addInstallerListener(CustomDataLoader.java:141)
        at com.izforge.izpack.installer.container.impl.CustomDataLoader.loadCustomData(CustomDataLoader.java:116)
        at com.izforge.izpack.installer.container.impl.InstallerContainer.resolveComponents(InstallerContainer.java:145)
        at com.izforge.izpack.installer.container.impl.GUIInstallerContainer.resolveComponents(GUIInstallerContainer.java:94)
        at com.izforge.izpack.installer.container.impl.InstallerContainer.fillContainer(InstallerContainer.java:79)
        at com.izforge.izpack.core.container.AbstractContainer.initialise(AbstractContainer.java:303)
        at com.izforge.izpack.core.container.AbstractContainer.initialise(AbstractContainer.java:283)
        at com.izforge.izpack.installer.container.impl.GUIInstallerContainer.<init>(GUIInstallerContainer.java:44)
        at com.izforge.izpack.installer.bootstrap.InstallerGui.run(InstallerGui.java:43)
        at com.izforge.izpack.installer.bootstrap.Installer.launchInstall(Installer.java:21)
        at com.izforge.izpack.installer.bootstrap.Installer.start(Installer.java:193)
        at com.izforge.izpack.installer.bootstrap.Installer.main(Installer.java:72)

This happens apparently before the <javaversion> tag is evaluated and therefore doesn't lead to a "controlled" stopping of the installer with a reasonable user dialog informing the user about a mismatching.Java version.

Using the application in console mode and with Spanish as language, I have realized that some text and labels have been set in English hardcoded.

For example, I have found
1.
class "TargetConsolePanel"
method "public boolean run(InstallData installData, Console console)"
text: "Select target path ["

2.
class "ConsoleChoiceField"
method "public boolean More ...display()"
text: "input selection: "

I don't know if it could be more text hardcoded like that. I have found this ones at the moment.

This feature is inspired by the useful utility Maven Config Processor Plugin:

The above utility allows to modify properties and xml files by removing, modifying or adding elements based on transformation rules defined in XML and especially for XML patching using XPath expressions.

The tool is very sophisticated and could be integrated as optional feature / listener to IzPack, as a complement to the ConfigurationInstallerListener. In comparison to the Config Processor the latter one does a just three-way merge of files directly using rules for patching, which is a different use case.

There should be a possibility to interrupt a running target and waiting for a user response.
This could be achieved by a special Ant task utilizing IzPack messageboxes (error, warning, information).
Translating error messages should be possible from this task.
There might be also the possibility to retry a certain block of Ant code if the user wishes it.

Some installers – such as those for alpha, beta, or test versions of a product – need to expire to prevent use after a given date. While the installed program can (and should) time out, it would be frustrating and bad form to let a user install an expired program.

This can be implemented as an optional variable:

<variables>
...
<!-- Make the installer expire -->
<variable name="InstallerExpiresDate" value="2016-01-01" />
...
</variables>

Assuming the following configuration file wrapper.conf:

wrapper.java.command=C:\Program Files\Java\jdk1.7.0_51\bin\java

and the following dynamic variable definition:

<variable name="java.cmd" type="options" escape="false" ignorefailure="true" file="${INSTALL_PATH}/bin/wrapper.conf" key="wrapper.java.command">
  <filters>
    <regex regexp="[/\\]+" replace="/" global="true" />
  </filters>
</variable>

After refreshing. the variable java.cmd should have been evaluated to C:/Program Files/Java/jdk1.7.0_51/bin/java.
Actually It contains C:Program FilesJavajdk1.7.0_51/bin/java.

This happens just for reading values from files, plain values with backslashes work as expected.

We need an approach to decrease the installer size depending on the user's needs and at the same time offer an approach how to add and isolate features which need additional external libraries or other resources. In the past, there have been often blocked good ideas because they would introduce overhead and increase the installer size for all users, not just for those using that idea.

The best way we currently offer are listeners, but they don't separate resources and external libraries. For instance, the ConfigurationInstallerListener for merging configuration files needs to define:

• the listener in the <listeners> section
• the resource "ConfigurationActionsSpec.xml" in the <resources> section
• jdom2.jar, jaxen.jar etc. as <jar> elements
• mapping/renaming of configuration files when overwriting, for example to *.configbak

The above items could be ideally added as feature, maybe having its descriptor or even source code (Maven module) completely separated.
The IzPack "feature" discussed here should completely replace old-style listeners. All listeners should be written as features and assembled separately, not in the basic elements of install.xml (resources, jar, listeners, packs, ...).

A feature should be defined as one block of XML in install.xml and might consist of:

• a name
• an optional set of jar files additionally needed at runtime
• a optional set of orther binary or text resources additionally needed at runtime
• additional translations
• a set of panel implementations
• prerequisites which might have been check at install time (OS, architecture, JRE, ...)
• ...

The implementation should then plug into a given API which is still to define. Plugin points could be:

• execution beforepacks (before any pack is installed)
• execution beforepack (immediately before files of a certain pack are installed)
• execution afterpacks after all pack is installed)
• execution afterpack (immediately after file of a certain pack are installed)
• execution beforefile (before a file is installed)
• execution afterfile (after a file has been installed)
• mapping of file names for installed files
• the progress bar
• logging
• ...

This API should be versioned and stable within one and the same version. An API version might have prerequisites, like the minimum JDK/JRE version supported, increasing the minimum required JDK should increase the API version.
Another consideration is giving features an own classloader, containing the IzPack plus its additional classpath. This feature classpath will not be available in the rest of the IzPack code. This way there can be ensured using of one and the same fully qualified classnames, but with different meaning or different versions between two different features.
There should be a set of standard features available for IzPack built along with IzPack itself

This issue is still an open discussion.
The main goals are clear:

• make the resulting installers contain exactly what the user needs, without megabytes of overhead
• make definitions in install.xml more transparent - divide the knowledges between assembling a feature (feature developer) and using a feature.

When using dynamic variables with a condition, which depends on a dependent dynamic variable the refresh() loop is terminated to early since IZPACK-1213.

<dynamicvariables>
  <variable name="var1" value="1" checkonce="true" />
  <variable name="var1" value="2" checkonce="true" condition="cond1"/>
  <variable name="var2" value="${var1}" />
  <variable name="var3" value="${var2}" />
  <variable name="var4" value="${var3}" />
  <variable name="var5" value="${var4}" />
</dynamicvariables>

<conditions>
  <condition id="cond1" type="variable"> <name>var5</name> <value>1</value> </condition>
</conditions>

A cyclic reference like

<dynamicvariables>
  <variable name="a" value="${b}" />
  <variable name="b" value="${a}" />
</dynamicvariables>

produce a loop (at least since inclusion of IZPACK-1182).

The cyclic reference is not a valid definition of course, but the installer should detect and report the loop.

Fields that inherit from AbstractConsoleFileField with read readonly=true will cause the console panel to rerun when it shouldn't.

Using dynamic variables with the same name but different conditions like the following example from http://docs.codehaus.org/display/IZPACK/Lifecycle+of+dynamic+variables does not work

<dynamicvariables>
<variable name="thechoice" value="fallback value">
<variable name="thechoice" value="choice1" condition="cond1">
<variable name="thechoice" value="choice2" condition="cond2">
</dynamicvariables>

I would expect the "fallback value" only then, when neither cond1 nor cond2 is true. As soon as one of the conditions is set, the value should change.

Supposed there is the following installer defined:
userInputSpec.xml:

<izpack:userinput version="5.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:izpack="https://izpack.github.io/schema/userinput" xsi:schemaLocation="https://izpack.github.io/schema/userinput https://izpack.github.io/schema/5.0/izpack-userinput-5.0.xsd">

  <panel id="panel.test">
    <field type="title" txt="Test panel" id="text.test.title" />
    <field type="radio" variable="dbsystem">
      <spec txt="with set">
        <choice txt="MSSQL" value="mssql" id="text.dbsystem.mssql" />
    <choice txt="Oracle" value="oracle" id="text.dbsystem.oracle" set="true" />
    <choice txt="SAP Hana" value="hdb" id="text.dbsystem.hana" />
      </spec>
    </field>
    <field type="divider"/>
    <field type="radio" variable="dbsystem2">
      <spec txt="with default">
    <choice txt="MSSQL" value="mssql" id="text.dbsystem.mssql" />
    <choice txt="Oracle" value="oracle" id="text.dbsystem.oracle" default="true" />
    <choice txt="SAP Hana" value="hdb" id="text.dbsystem.hana" />
      </spec>
    </field>
    <field type="divider"/>
    <field type="radio" variable="dbsystem3">
      <spec txt="just relying on variable">
        <choice txt="MSSQL" value="mssql" id="text.dbsystem.mssql" />
        <choice txt="Oracle" value="oracle" id="text.dbsystem.oracle" />
        <choice txt="SAP Hana" value="hdb" id="text.dbsystem.hana" />
      </spec>
    </field>
  </panel>

</izpack:userinput>

install.xml

  ...
  <conditions>
    <condition type="exists" id="haveInstallPath">
      <variable>INSTALL_PATH</variable>
    </condition>
  </conditions>
  ....
  <dynamicvariables>
    <variable name="dbsystem" value="mssql" condition="!haveInstallPath"/>
    <variable name="dbsystem" value="hdb" condition="haveInstallPath"/>
    <variable name="dbsystem2" value="mssql" condition="!haveInstallPath"/>
    <variable name="dbsystem2" value="hdb" condition="haveInstallPath"/>
    <variable name="dbsystem3" value="mssql" condition="!haveInstallPath"/>
    <variable name="dbsystem3" value="hdb" condition="haveInstallPath"/>
  </dynamicvariables>
  ....
  <panels>
    <panel classname="TargetPanel" id="panel.target"/>
    <panel classname="UserInputPanel" id="panel.test"/>
    <panel classname="InstallPanel"/>
  </panels>
  ...

There are always working the defaults just for the first of the radio fields, not for the subsequent fields, regardless if the default should come from the variable value itself or from the set/default attributes of each choice.

Provided there is a panel specification in userInputSpec.xml like this:

<panel id="panel.test">
    <field type="title" txt="Test panel" id="text.test.title" />
    <field type="staticText" align="left" txt="${INSTALL_PATH}${FILE_SEPARATOR}${application.folder}" />
    <field type="text" variable="targetsettings.target">
    <spec txt="Target directory: ${INSTALL_PATH}${FILE_SEPARATOR}" id="text.targetsettings.target" size="20" set="${application.folder}" />
         <validator class="com.izforge.izpack.panels.userinput.validator.NotEmptyValidator" txt="Target directory path is mandatory!" id="text.targetsettings.target.error" />
    </field>
</panel>

and a <panel> section in install.xml like this

<panels>
    <panel classname="TargetPanel" id="panel.target"/>
    <panel classname="UserInputPanel" id="panel.test"/>
    ...
</panels>

there doesn't happen any variable resolution for the txt="Target directory: ${INSTALL_PATH}${FILE_SEPARATOR}" attribute value including its translations although the according variables are set.

Should be translated here to make variable replacement consistent everywhere.

Attempting to build izpack from master results in the following errors:
[ERROR] /home/thauser/community/izpack/izpack-util/src/main/java/com/izforge/izpack/util/config/base/BasicProfile.java:[159,29] remove(java.lang.Object,java.lang.Object) in com.izforge.izpack.util.config.base.BasicProfile cannot implement remove(java.lang.Object,java.lang.Object) in java.util.Map
[ERROR] return type java.lang.String is not compatible with boolean
[ERROR] /home/thauser/community/izpack/izpack-util/src/main/java/com/izforge/izpack/util/config/base/BasicRegistry.java:[28,8] remove(java.lang.Object,java.lang.Object) in com.izforge.izpack.util.config.base.BasicProfile cannot implement remove(java.lang.Object,java.lang.Object) in java.util.Map
[ERROR] return type java.lang.String is not compatible with boolean
[ERROR] /home/thauser/community/izpack/izpack-util/src/main/java/com/izforge/izpack/util/config/base/Profile.java:[59,12] remove(java.lang.Object,java.lang.Object) in com.izforge.izpack.util.config.base.Profile clashes with remove(java.lang.Object,java.lang.Object) in java.util.Map
[ERROR] return type java.lang.String is not compatible with boolean
[ERROR] /home/thauser/community/izpack/izpack-util/src/main/java/com/izforge/izpack/util/config/base/Ini.java:[32,8] remove(java.lang.Object,java.lang.Object) in com.izforge.izpack.util.config.base.BasicProfile cannot implement remove(java.lang.Object,java.lang.Object) in java.util.Map
[ERROR] return type java.lang.String is not compatible with boolean
[ERROR] /home/thauser/community/izpack/izpack-util/src/main/java/com/izforge/izpack/util/config/base/Reg.java:[32,8] remove(java.lang.Object,java.lang.Object) in com.izforge.izpack.util.config.base.BasicProfile cannot implement remove(java.lang.Object,java.lang.Object) in java.util.Map
[ERROR] return type java.lang.String is not compatible with boolean
[ERROR] /home/thauser/community/izpack/izpack-util/src/main/java/com/izforge/izpack/util/config/base/Wini.java:[32,8] remove(java.lang.Object,java.lang.Object) in com.izforge.izpack.util.config.base.BasicProfile cannot implement remove(java.lang.Object,java.lang.Object) in java.util.Map
[ERROR] return type java.lang.String is not compatible with boolean
[ERROR] /home/thauser/community/izpack/izpack-util/src/main/java/com/izforge/izpack/util/config/base/ConfigParser.java:[410,12] remove(java.lang.Object,java.lang.Object) in com.izforge.izpack.util.config.base.BasicProfile cannot implement remove(java.lang.Object,java.lang.Object) in java.util.Map
[ERROR] return type java.lang.String is not compatible with boolean

This is caused by a new method in the Map interface in Java 8, which has the same method signature as the remove(Object,Object) in Profile except that it returns a boolean.

Hi,

I Would like to contribute to the documentation because I'm using izpack and i notice errors in documentation. I dont known how to get a wiki account.

Sorry for my english.

Errors found :

http://docs.codehaus.org/display/IZPACK/Windows+Registry+Access and
http://docs.codehaus.org/pages/viewpage.action?pageId=230398039 :

The end tag "natives" miss "/"

http://docs.codehaus.org/pages/viewpage.action?pageId=230398039 :

The correct call to the listener seems to be :
<listeners>
<listener classname="RegistryInstallerListener" stage="install" >
<os family="windows"/>
</listener>
<listener classname="RegistryUninstallerListener" stage="uninstall" >
<os family="windows"/>
</listener>
</listeners>

In future, it should be possible to define panel configuration entries using the element name as the option name directly, similar to Maven.

Additionally there should be used optional conditions which must evaluate true before the given value applies.

The old syntax <param name="..." value="..." /> will be preserved for compatibility reasons to not break older environments, but I will recommend to use the newer one.

Example:

<panel classname="TargetPanel" id="panel.target">
  <configuration>
    <!-- Don't show warning if target directory already exists -->
    <param name="ShowExistingDirectoryWarning" value="false" />
  </configuration>
</panel>

should be written now:

<panel classname="TargetPanel" id="panel.target">
  <configuration>
    <!-- Don't show warning if target directory already exists -->
    <ShowExistingDirectoryWarning>false</ShowExistingDirectoryWarning>
  </configuration>
</panel>

which can be enhanced by a condition:

<panel classname="TargetPanel" id="panel.target">
  <configuration>
    <!-- Don't show warning if target directory already exists -->
    <ShowExistingDirectoryWarning condition="isUninstaller|isUpdate">false</ShowExistingDirectoryWarning>
  </configuration>
</panel>

On TargetPanel, there is a message TargetPanel.warn ("The directory already exists! Are you sure you want to install here and possibly overwrite existing files?") shown uncondtionally.

This might be inconvenient if you want to provide an update installer, which counts with existing files in the target directory.

An option would be needed for being able to deactivate this warning and continue wit the installation.

Note:
There is already a optional ShowCreateDirectoryMessage boolean IzPack variable used for controlling a similar warning whether the target directory should be created if it doesn't exist. This approach might be enough for now.

Currently, if there is a pack definition like this:

<packs>
    <pack name="Templates" required="no" id="pack.templates" condition="withTemplates">
      <description>Templates</description>
      <fileset dir="@{izpack.staging.directory}/templates" />
    </pack>
    ...
</packs>

if the pack condition withTemplates evaluates true, the pack is just selected and a user change is skipped in a console mode installation.
This behavior is different from the established behavior in the GUI PacksPanel, like described more detailled recently in http://docs.codehaus.org/display/IZPACK/Packs.

The PacksConsolePanel should use the same logic for the condition and required attributes like the PacksPanel.

Read-only fields on UserInputPanel does still not work as designed and described in http://docs.codehaus.org/display/IZPACK/Displaying+panels+and+fields+read-only.

Especially overriding these attributes on panel level for all single panel fields not defining the same attribute and override the panel attribute value on field level had the wrong behavior.

The GUI as well as console installer mode is affected by these problems in a different manner.

There is a couple of bug fixes and improvements to implement in UserInputPanel towards to 5.0. They are added as subissues.

On the panel

  <panel id="panel.dboperation" summaryKey="key.dboperation.title">
    <field type="title" txt="Database operation selection" id="text.dboperation.title" />
    <field type="staticText" align="left" txt="Choose the preferred database action:" id="text.dboperation.description" />
    <field type="space" />
    <field type="radio" variable="db.operation" summaryKey="key.dboperation">
      <spec>
        <choice txt="Build instance as administrator" value="create_instance" id="text.dboperation.create_instance" conditionid="Install"/>
        <choice txt="Rebuild instance as administrator" value="recreate_instance" id="text.dboperation.recreate_instance" conditionid="Install"/>
        <choice txt="Build structure as existing user" value="create_structure" id="text.dboperation.create_structure" conditionid="Install"/>
        <choice txt="Rebuild structure as existing user" value="recreate_structure" id="text.dboperation.recreate_structure" conditionid="Install"/>
        <choice txt="Don't touch, already manually installed" value="create_none" id="text.dboperation.create_none" conditionid="Install"/>
        <choice txt="Update existing instance as administrator" value="update_instance" id="text.dboperation.update" conditionid="Update"/>
        <choice txt="Update existing structure as existing user" value="update_structure" id="text.dboperation.update" conditionid="Update"/>
        <choice txt="Don't touch, already manually updated" value="update_none" id="text.dboperation.update_none" conditionid="Update"/>
        <choice txt="Drop instance as administrator" value="drop_instance" id="text.dboperation.drop_instance" conditionid="Uninstall"/>
        <choice txt="Drop structure as existing user" value="drop_structure" id="text.dboperation.drop_structure" conditionid="Uninstall"/>
        <choice txt="Don't touch, drop manually later" value="drop_none" id="text.dboperation.drop_none" conditionid="Uninstall"/>
      </spec>
    </field>
  </panel>

There don't work the single choice conditions correctly. Actually their conditions are evaluated just on installer start, the state of the choice conditions when the panel gets really activated is ignored.

The <choice ... conditionid="..." /> attribute was initially meant to hide the appropriate choice when the condition is not met when the panel get activated, before laying out the panel.